Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tool passive bindings support #1430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Adithyan-Dinesh-Trenser

Context

Added support for setting bindings when ToolGroup.setToolPassive is called. Modified as part of this OHIF PR

Changes & Results

  • Added an optional parameter 'bindings' which will used as the tool bindings if provided.
  • When calling ToolGroup.setToolPassive, keep the tool passive if all the remaining filtered bindings have the primary button. This can be used to keep extra primary mouse button + key combinations for a tool to each exhibit different behaviour of the same tool.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11 Pro
  • Node version: 18.17.0
  • Browser: Chrome 127.0.6533.120 (Official Build) (64-bit)

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 19a6991
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/66fe8caa5a9ad60008064d67
😎 Deploy Preview https://deploy-preview-1430--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Adithyan-Dinesh-Trenser
Copy link
Author

Cc : @Ouwen

@Adithyan-Dinesh-Trenser Adithyan-Dinesh-Trenser force-pushed the feat/set-tool-passive-bindings-support branch from 80ffbed to 5092c9a Compare September 27, 2024 12:35
@Adithyan-Dinesh-Trenser Adithyan-Dinesh-Trenser force-pushed the feat/set-tool-passive-bindings-support branch from 5092c9a to 19a6991 Compare October 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant